Skip to content

CLVM/CLVM_NG: Host HA support, lock retry, lease-based lock holder lookup and template LV cleanup fix - #14450

Draft
Pearl1594 wants to merge 6 commits into
mainfrom
clvm-ha-support
Draft

CLVM/CLVM_NG: Host HA support, lock retry, lease-based lock holder lookup and template LV cleanup fix#14450
Pearl1594 wants to merge 6 commits into
mainfrom
clvm-ha-support

CLVM: send the sanlock host id with the fence command and report host…

97f176f
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Nov 13, 2026 in 5m 22s

Quality Gate passed

Issues
53 New issues
0 Accepted issues

Measures
0 Security Hotspots
55.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 1569 in server/src/test/java/com/cloud/template/TemplateManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzeQL9Hl71vwLuQl&open=AaHAuzeQL9Hl71vwLuQl&pullRequest=14450

Check warning on line 1562 in server/src/test/java/com/cloud/storage/ClvmPoolManagerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHSSFtUajHsZZ1tkZ2F&open=AaHSSFtUajHsZZ1tkZ2F&pullRequest=14450

Check warning on line 828 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuyz7L9Hl71vwLuQK&open=AaHAuyz7L9Hl71vwLuQK&pullRequest=14450

Check warning on line 1632 in server/src/test/java/com/cloud/storage/ClvmPoolManagerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzaDL9Hl71vwLuQe&open=AaHAuzaDL9Hl71vwLuQe&pullRequest=14450

Check warning on line 827 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuyz7L9Hl71vwLuQJ&open=AaHAuyz7L9Hl71vwLuQJ&pullRequest=14450

Check failure on line 223 in engine/storage/volume/src/main/java/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use static access with "org.apache.cloudstack.alert.AlertService" for "AlertType". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuyHFL9Hl71vwLuQE&open=AaHAuyHFL9Hl71vwLuQE&pullRequest=14450

Check warning on line 1244 in server/src/main/java/com/cloud/template/TemplateManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this if-then-else statement by a single return statement. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzWYL9Hl71vwLuQc&open=AaHAuzWYL9Hl71vwLuQc&pullRequest=14450

Check warning on line 37 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/clvm/ClvmSanlockLeaseReader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a private constructor to hide the implicit public one. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzMeL9Hl71vwLuQO&open=AaHAuzMeL9Hl71vwLuQO&pullRequest=14450

Check failure on line 96 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Advanced" 4 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFa_-PpdA74Gae3fbB3&open=AaFa_-PpdA74Gae3fbB3&pullRequest=14450

Check warning on line 1569 in server/src/test/java/com/cloud/template/TemplateManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "never". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzeQL9Hl71vwLuQm&open=AaHAuzeQL9Hl71vwLuQm&pullRequest=14450

Check warning on line 104 in engine/storage/volume/src/main/java/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuyHFL9Hl71vwLuQD&open=AaHAuyHFL9Hl71vwLuQD&pullRequest=14450

Check warning on line 380 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Method has 9 parameters, which is greater than 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzSEL9Hl71vwLuQV&open=AaHAuzSEL9Hl71vwLuQV&pullRequest=14450

Check failure on line 368 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Null is returned but a "Boolean" is expected. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzSEL9Hl71vwLuQZ&open=AaHAuzSEL9Hl71vwLuQZ&pullRequest=14450

Check warning on line 82 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzSEL9Hl71vwLuQT&open=AaHAuzSEL9Hl71vwLuQT&pullRequest=14450

Check failure on line 364 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Null is returned but a "Boolean" is expected. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzSEL9Hl71vwLuQY&open=AaHAuzSEL9Hl71vwLuQY&pullRequest=14450

Check warning on line 2311 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuywGL9Hl71vwLuQH&open=AaHAuywGL9Hl71vwLuQH&pullRequest=14450

Check warning on line 125 in plugins/hypervisors/kvm/src/test/java/org/apache/cloudstack/kvm/ha/KVMHostActivityCheckerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFa_9-DdA74Gae3fbB0&open=AaFa_9-DdA74Gae3fbB0&pullRequest=14450

Check warning on line 1536 in server/src/test/java/com/cloud/template/TemplateManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzeQL9Hl71vwLuQf&open=AaHAuzeQL9Hl71vwLuQf&pullRequest=14450

Check warning on line 172 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/clvm/ClvmSanlockLeaseReader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzMeL9Hl71vwLuQN&open=AaHAuzMeL9Hl71vwLuQN&pullRequest=14450

Check warning on line 80 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzSEL9Hl71vwLuQU&open=AaHAuzSEL9Hl71vwLuQU&pullRequest=14450

Check warning on line 1604 in server/src/test/java/com/cloud/storage/ClvmPoolManagerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "never". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHSSFtUajHsZZ1tkZ2H&open=AaHSSFtUajHsZZ1tkZ2H&pullRequest=14450

Check warning on line 83 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_storagePoolDao" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzSEL9Hl71vwLuQS&open=AaHAuzSEL9Hl71vwLuQS&pullRequest=14450

Check warning on line 354 in server/src/main/java/com/cloud/template/TemplateManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzWYL9Hl71vwLuQb&open=AaHAuzWYL9Hl71vwLuQb&pullRequest=14450

Check failure on line 201 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "null answer" 4 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzSEL9Hl71vwLuQQ&open=AaHAuzSEL9Hl71vwLuQQ&pullRequest=14450

Check warning on line 2288 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuywGL9Hl71vwLuQG&open=AaHAuywGL9Hl71vwLuQG&pullRequest=14450
View more details on SonarQubeCloud