Repository navigation
use ConfigKeys for UCS settings and remaining getValue() literals - #14472
Open
DaanHoogland wants to merge 2 commits into
Open
DaanHoogland wants to merge 2 commits into
DaanHoogland wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## ghi10752-config-foundation #14472 +/- ##
=================================================================
+ Coverage 3.86% 20.81% +16.95%
- Complexity 0 20859 +20859
=================================================================
Files 494 6069 +5575
Lines 42875 548528 +505653
Branches 8136 73236 +65100
=================================================================
+ Hits 1657 114179 +112522
- Misses 40986 420985 +379999
- Partials 232 13364 +13132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 25.75% |
| Branch coverage | 20.87% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
DaanHoogland
force-pushed
the
ghi10752-config-foundation
branch
from
October 27, 2026 11:36
86803e8 to
c800b90
Compare
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
DaanHoogland
force-pushed
the
ghi10752-config-literals
branch
from
October 27, 2026 17:08
a7fff83 to
aa20afc
Compare
DaanHoogland
force-pushed
the
ghi10752-config-foundation
branch
from
October 28, 2026 07:28
c800b90 to
1a6e967
Compare
DaanHoogland
force-pushed
the
ghi10752-config-literals
branch
from
October 28, 2026 07:51
aa20afc to
c407c4a
Compare
Part of the split of #13884 (phase out the Config enum, #10752). Co-Authored-By: Claude Opus 5.5 <[email protected]>
Also hand the ResourceManagerImplTest and ManagementServerImplTest changes to the PR that changes the code they test. Co-Authored-By: Claude Opus 5.5 <[email protected]>
DaanHoogland
force-pushed
the
ghi10752-config-foundation
branch
from
November 13, 2026 16:14
1a6e967 to
a7194f9
Compare
DaanHoogland
force-pushed
the
ghi10752-config-literals
branch
from
November 13, 2026 16:14
c407c4a to
80a479e
Compare
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switches the UCS settings and the remaining string-literal
ConfigurationDao.getValue("...")lookups toConfigKeys.Split out of #13884 (phase out the deprecated
Configenum, #10752). Depends on #14467. Independent of the other PRs that depend on #14467, so it can be reviewed and merged in any order relative to them; GitHub retargets it tomainonce #14467 is merged.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?
Local verification: full reactor build (checkstyle included) and the unit tests of every touched module pass on this branch; merging all PRs of the split in any order gives no conflicts and reproduces #13884 plus its fixes.
🤖 Generated with Claude Code