Repository navigation
use ConfigKeys for ManagementServer, agent, secondary storage and router settings - #14474
Open
DaanHoogland wants to merge 1 commit into
Open
DaanHoogland wants to merge 1 commit into
DaanHoogland wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## ghi10752-config-core-1 #14474 +/- ##
===========================================================
Coverage 20.80% 20.80%
+ Complexity 20846 20845 -1
===========================================================
Files 6069 6069
Lines 548488 548481 -7
Branches 78659 73218 -5441
===========================================================
+ Hits 114120 114121 +1
+ Misses 421033 421027 -6
+ Partials 13335 13333 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 25.73% |
| Branch coverage | 20.84% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
DaanHoogland
force-pushed
the
ghi10752-config-core-2
branch
from
October 23, 2026 14:58
0ddab00 to
f44e26f
Compare
DaanHoogland
force-pushed
the
ghi10752-config-core-2
branch
from
October 27, 2026 17:08
f44e26f to
1803736
Compare
DaanHoogland
force-pushed
the
ghi10752-config-core-2
branch
from
October 28, 2026 07:51
1803736 to
149bbda
Compare
…ter settings Part of the split of #13884 (phase out the Config enum, #10752). Co-Authored-By: Claude Opus 5.5 <[email protected]>
DaanHoogland
force-pushed
the
ghi10752-config-core-2
branch
from
November 13, 2026 16:14
149bbda to
98a3221
Compare
Open
3 of 14 tasks
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restructures the
ManagementServersettings and switches the agent, secondary storage VM and virtual router call sites toConfigKeys.Split out of #13884 (phase out the deprecated
Configenum, #10752). Depends on #14473; merge after it.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?
Local verification: full reactor build (checkstyle included) and the unit tests of every touched module pass on this branch; merging all PRs of the split in any order gives no conflicts and reproduces #13884 plus its fixes.
🤖 Generated with Claude Code