Repository navigation
skip empty summaries in AggregateSummaryStatistics.aggregate - #354
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #354 +/- ##
============================================
+ Coverage 86.54% 87.21% +0.66%
+ Complexity 9787 91 -9696
============================================
Files 532 499 -33
Lines 35516 33538 -1978
Branches 6194 5855 -339
============================================
- Hits 30738 29250 -1488
+ Misses 3518 3164 -354
+ Partials 1260 1124 -136 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On master, with
SummaryStatisticspartitions:SummaryStatisticsreports NaN for every statistic while it holds no values, andAggregateSummaryStatistics.aggregatefolds each summary in unconditionally:JdkMath.min/maxpropagate the NaN, and the sum, mean and second moment pick it up through the running totals. One empty partition anywhere in the collection therefore wipes out the combined result, although the javadoc says it should match a single summary over the combined data. Empty partitions are routine when work is split across threads or groups. The NaN-tolerant min/max removed in MATH-1671 masked part of this; the variance was already lost before that.Summaries with
getN() == 0are now skipped, both when picking the starting summary and in the accumulation loop, and the javadoc says so. An all-empty collection still returns n = 0 with NaN statistics, as before.AggregateSummaryStatisticsTest.testAggregateEmptySummariesputs empty partitions at the start, middle and end. On master it fails withexpected:<5.0> but was:<NaN>; it passes with the patch.mvn clean verify javadoc:javadoc -pl commons-math-legacy -amis green on JDK 21 (3264 tests in legacy, Checkstyle and SpotBugs clean).