Repository navigation
Add consumer fields, body text fields and sorting - #104
Merged
Merged
Conversation
- Add consumer_identifier, consumer_name and consumer_group to request-logs and metrics - Add request_body_text and response_body_text to request-logs - Add --sort-by and --sort-direction to request-logs and traces - Make --since optional for request-logs with a request_uuid filter - Output consumer_identifier in request-details - Update filter docs in help texts and the agent skill
- Remove repeated consumer and sorting guidance from the skill - Remove the consumer activity pattern, now a one-line filter - State at --limit which rows are kept without sort flags - Explain when to use the body text and body JSON fields
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 8 files
Heads up: you’re close to your included review allowance. Set a flex budget so reviews don’t pause.
Fix all with cubic | Re-trigger cubic
- request-logs returns consumer_identifier instead of consumer_id by default - consumers outputs the group as its name instead of an object - The skill uses the identifier to filter, group and join consumers
Rust 1.100 changed the build directory layout, which cargo-llvm-cov 0.8.5 does not support.
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 7 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic | Re-trigger cubic
- A limit returns the oldest rows only without sort flags - not_exists is not one of the operators that also match missing or null values
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
==========================================
+ Coverage 92.01% 94.18% +2.17%
==========================================
Files 13 13
Lines 2491 2613 +122
==========================================
+ Hits 2292 2461 +169
+ Misses 199 152 -47 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes
request-logsreturnsconsumer_identifierinstead ofconsumer_idby default. Requestconsumer_idwith--fieldsif needed.consumersoutputs the group as its name ("group":"Admins") instead of an object withidandname.Changes
consumer_identifier,consumer_nameandconsumer_grouptorequest-logs(fields and filters) andmetrics(group-by and filters), with new columns in the DuckDBrequest_logsandmetricstables (added to existing databases withALTER TABLE).request-logsitself.request_body_textandresponse_body_texttorequest-logs, with new columns in the DuckDBrequest_logstable. The help and skill explain when to use the text fields and when the JSON fields.--sort-byand--sort-directiontorequest-logsandtraces. The--limithelp states which rows are kept without sort flags.--sinceoptional forrequest-logs; the API requires it unless arequest_uuidfilter useseqorin.request-detailsoutputsconsumer_identifierand writes it to therequest_logstable.--filtershelp formetrics,request-logsandtraces, and the shared Filters section inreferences/commands.md:request_body_jsonandresponse_body_jsonfilters require a JSONPathkey.neqand thenot_operators also match rows where the field or key is missing or null.eq,neq,inandnot_inalso compare values as text, andis_null/is_not_nullare accepted with akey.consumersis for custom attributes and the times of a consumer's first and last request.