Repository navigation
Conversation
…s no urls When single_version_override was used without urls, e.g. to only set libpython or distutils, the strip_prefix of all platforms was reset to the tag default. The archives of the full flavor, which are used for the freethreaded builds of some versions, need a different strip_prefix, so keep the existing strip_prefix when the archives are not overridden.
Collaborator
Author
|
This PR was drafted by an AI coding agent (Claude Code) working for @aignas as part of the plan in #3902. It stays a draft until @aignas has reviewed it. Review comments will be handled by @aignas, possibly with the help of the agent; any agent-written replies will be marked as such. Agent-generated comment, posted automatically on behalf of the user. |
aignas
marked this pull request as ready for review
November 8, 2026 12:18
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the
strip_prefixof the existing archives whenpython.single_version_overridedoes not override theurls.Before this change, an override that only sets e.g.
libpythonordistutilsreset thestrip_prefixof every platform to the tag defaultpython. Some versions (e.g. 3.13.0) use thefullarchives for thefreethreaded builds, which need
python/install, so such an override brokethose toolchains. The
strip_prefixfrom the tag is still used for theplatforms whose
urlsandsha256are overridden.This is needed for #4434, which makes
single_version_overridethe way to setthe
coverage_toolfor all platforms of a version.