Repository navigation
fix(pypi): enable pip.default.envsubst for pip.default.index_url - #4438
Merged
Merged
Conversation
It turns out that pip.parse.envsubst could not reasonably be used together with pip.default.index_url, as there could be multiple pip.parse tags with varying contents, so pip.default.index_url would not always be processed in the same way. To cope with this, we here introduce pip.default.envsubst, which can effectively be used together with pip.default.index_url. Closes bazel-contrib#4123
aignas
approved these changes
Nov 8, 2026
aignas
left a comment
aignas
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, but needs a news entry.
aignas
reviewed
Nov 8, 2026
Only mention Bazel 7 in the note about re-fetching, add a versionadded note and a news entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that pip.parse.envsubst could not reasonably be used together
with pip.default.index_url, as there could be multiple pip.parse tags
with varying contents, so pip.default.index_url would not always be
processed in the same way.
To cope with this, we here introduce pip.default.envsubst, which can
effectively be used together with pip.default.index_url.
This also fixes a testing bug where envsubst was not a list.
Closes #4123