Repository navigation
cmake: require CMake 3.13; build the tests without a PCH below 3.16 - #145
Merged
Merged
Conversation
The library itself needs nothing newer than 3.13 (the version Boost.CI now uses as its floor). Only the tests wanted 3.16, for target_precompile_headers, so guard that and let older CMake build them without the shared PCH - slower, not different. Configured, built and ran the tests (215/215) with CMake 3.13.0. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
An automated preview of the documentation is available at https://145.openmethod.prtest3.cppalliance.org/libs/openmethod/doc/html/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-11-10 22:42:22 UTC |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #145 +/- ##
========================================
Coverage 92.56% 92.57%
========================================
Files 29 29
Lines 2314 2316 +2
Branches 699 699
========================================
+ Hits 2142 2144 +2
Misses 111 111
Partials 61 61 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Written by Claude Code, on behalf of @jll63.)
Follow-up to #144, which raised the declared minimum to 3.16 because the tests call
target_precompile_headers. That command is the only thing that needs 3.16, and it is only an optimisation, so this PR goes back down to 3.13:cmake_minimum_required(VERSION 3.13...3.20)in the rootCMakeLists.txtand intest/cmake_test/CMakeLists.txt.test/CMakeLists.txtis used only whenCMAKE_VERSIONis at least 3.16. Older CMake builds the tests without it: slower, not different.3.13 is also the lower bound Boost.CI now uses (boostorg/boost-ci
7d792d689, "Use CMake 3.13 as lower bound"): below it, CMake does not install the package config files.Testing
CMake 3.13.0 (the Linux binary from cmake.org), standalone build against a Boost super-project checkout, GCC, Debug: configure, build of the
teststarget, andctest: 215/215 tests pass, with no precompiled headers.A configure of the same tree with a bare
cmake_minimum_required(VERSION 3.13)under CMake 3.28 and-Wdevprinted no policy warnings, so no policy introduced after 3.13 changes anything on that path. That was only exercised on Linux/GCC; the MSVC-specific paths were not.Not tested: the Boost.CI
Min. CMakejob on this branch (it will now build CMake 3.13), and Windows.🤖 Generated with Claude Code