Repository navigation
Add PHP 8.5 support for opentelemetry - #681
Merged
Merged
Conversation
Bump the opentelemetry extension from 1.1.0 to 1.4.2 (latest release on PECL) and build it for PHP 8.5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a PHP 8.5 build of the opentelemetry layer and bumps the extension from 1.1.0 to 1.4.2.
Why the bump: 1.1.0 is from early 2025. It builds and works on PHP 8.5, but one of its own tests fails there because of a PHP 8.5 deprecation in the test code (fixed in 1.2.1). Since 1.1.0 the extension also got refcount fixes and a JIT memory-safety fix. 1.4.2 is the latest release on PECL; 1.5.0 is not published on PECL, so the
pecl installrecipe can't use it.The bump also applies to the existing 82, 83 and 84 layers. For users of
hook()the behaviour is unchanged; the changes since 1.1.0 are bug fixes and a newopentelemetry.display_warningsini setting (default off).Tested locally on
bref/build-php-85:3:make test layer=opentelemetrypasses for 82, 83, 84 and 85.hook()with pre and post callbacks works on 8.5: pre replaces the arguments, post receives the exception.