Repository navigation
perf(pg): read integers, booleans and text straight from the row bytes - #3855
Open
nigrosimone wants to merge 1 commit into
Open
nigrosimone wants to merge 1 commit into
nigrosimone wants to merge 1 commit into
Conversation
nigrosimone
marked this pull request as ready for review
November 7, 2026 17:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3856. For every row we make a string for each value and only after we parse it: on 500 rows this is about half of the client time, and it is the biggest part of the gap with postgres 4.
This change was made looking at what postgres 4 does (release notes): the client now reads the rows directly from the socket buffer,
int2,int4,oidandboolare decoded from the bytes and text is decoded once. Parsers fromsetTypeParserget the string as before, array mode, binary mode andpg-cursorare not changed. I did not take the compiled row reader, here it gives little for the added complexity.With 1 row there is no real change. Measured with the same queries of the benchmark on local PostgreSQL 16 over TCP, not with the benchmark itself.
Test: unit tests compare the values with the parsers, and an integration test checks that a real query takes this path.