Repository navigation
Conversation
cache-sftp putdir left tmp/cache-sftp.putdir.* behind on the server when the rename failed (package already uploaded by another build) or when the upload aborted. These piled up until the cache disk was full. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Lars Erik Wik <[email protected]>
aleksandrychev
approved these changes
Nov 13, 2026
Contributor
Author
|
@cf-bottom Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/15107/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-15107/ |
craigcomstock
requested changes
Nov 13, 2026
craigcomstock
left a comment
craigcomstock
left a comment
Contributor
There was a problem hiding this comment.
one small wording change, seems reasonable
| " | ||
|
|
||
| # Remove the upload dir if the rename failed, e.g. because | ||
| # another buildslave uploaded the package first |
Contributor
There was a problem hiding this comment.
Suggested change
| # another buildslave uploaded the package first | |
| # another build host uploaded the package first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cache-sftp putdiruploads intotmp/cache-sftp.putdir.*on the cache server and then renames it into place. The temp dir was never removed when the rename failed (another build uploaded the package first) or when the upload aborted. These dirs piled up and filled the cache disk,.The temp dir is now removed after the rename, and again in a separate sftp session if the upload batch failed.
Generated with Claude Code