Repository navigation
fix: prefix AMQP extension application properties - #767
Open
yangjj-iso wants to merge 1 commit into
Open
yangjj-iso wants to merge 1 commit into
yangjj-iso wants to merge 1 commit into
Conversation
Preserve extensions through binary AMQP encode/decode for both supported CloudEvents versions and correct the existing writer expectations. Fixes cloudevents#766 Signed-off-by: redyyang <3202137046@qq.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #766.
Binary AMQP messages currently serialize extensions as bare application-property names, while the reader only accepts
cloudEvents:-prefixed names. For example, atraceparentor custom extension disappears after a writer/Proton encode/decode/reader round trip.Prefix the fallback extension names in
ProtonAmqpMessageWriter, as required by the AMQP binding's primary mapping. Correct the existing writer expectations and add real wire round-trip coverage for CloudEvents 0.3 and 1.0, includingtraceparent,tracestate, and a custom extension. The tests use no payload to isolate this change from #761.Validation:
MAVEN_OPTS=-Xmx384m ./mvnw -B -ntp -pl amqp -am verify -Dmaxmemory=256mpassed with 136 tests (API 8, core 90, AMQP 38), plus all three modules' Javadocs.git diff --checkpassed. No live broker or full-repository integration suite was run.AI assistance was used to investigate, implement, and test this change.