[karrgov]

Migration of the cf-java-client dependency

[theghost5800]

Some of comments are repeatable or not but overall do the checks through all the code again if possible

[theghost5800]

Some of comments are repeatable or not but overall do the checks through all the code again if possible

[theghost5800]

I don't see this changed, I expect to use similar structures as this method postForObject(String uri, Object body, Class<T> responseType, Object... uriVars). jobGuid to be passed as uriVar, not as concatenated String.

[theghost5800]

while (asyncJob == null || !asyncJob.isTerminal()) {
        long elapsedNanos = determineElapsedTime(startTimeNanos, timeout, jobGuid);
        long remainingNanos = timeoutNanos - elapsedNanos;

        Duration sleepDuration = interval.toNanos() > remainingNanos ? Duration.ofNanos(remainingNanos) : interval;
        sleep(sleepDuration);

        interval = nextInterval(interval);
        asyncJob = get(CloudControllerV3Endpoints.JOBS + jobGuid, V3Job.class);
    }

    if (asyncJob.isFailed()) {
        throw jobFailed(asyncJob);
    }
    return asyncJob;

Here is one solution which can avoid this.

Also I have notice in the current behaviour that there is no exit from the loop due to exceeded timeout which means if job doesn't return any success or failed state in expected timeout frame, then it will stuck indefinitely.

[sonarqubecloud]

Quality Gate failed

Failed conditions
78.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud