Repository navigation
fix: recursively sign promoted container images - #544
Open
ardentperf wants to merge 1 commit into
Open
ardentperf wants to merge 1 commit into
ardentperf wants to merge 1 commit into
Conversation
Add --recursive to the production image signing command so cosign signs the architecture-specific manifests as well as the multi-architecture index. This allows consumers enforcing signatures on individual manifests, such as Harbor, to verify the promoted images. Validated with Cosign v3.1.4 and a local OCI registry: child manifests fail verification before the change and both amd64 and arm64 manifests verify after running the updated signing step. GitHub OIDC and Harbor enforcement were not exercised. Fixes: cloudnative-pg#484 Assisted-by: OpenAI Codex Signed-off-by: Jeremy Schneider <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add --recursive to production image signing so Cosign signs each architecture-specific manifest as well as the multi-architecture index.
This is a one-line change to the production promotion action.
Validation: tested the actual signing step with Cosign v3.1.4 and a local OCI registry. Before the change, only the index verified; afterward, the index and both amd64 and arm64 manifests verified. YAML parsing, shell syntax, and git diff --check passed. GitHub OIDC and Harbor enforcement were not tested.
Fixes #484.
AI assistance: OpenAI Codex assisted with implementation and local validation.