Repository navigation
[rand.dist.samp.plinear] Fix densities() return size - #9377
Open
firmiana402 wants to merge 1 commit into
Open
firmiana402 wants to merge 1 commit into
firmiana402 wants to merge 1 commit into
Conversation
Member
|
This looks correct, given that we iterator |
eisenwave
added
the
P1-Important
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the specified size of the vector returned by
piecewise_linear_distribution::densities()fromnton + 1, matching the stated index range0, ..., n.piecewise_linear_distributionhas one density per interval boundary (n + 1values). [rand.dist.samp.plinear] explicitly states:This differs from
piecewise_constant_distribution, which has one density per subinterval and therefore onlyndensities.The incorrect size was already present in the repository's initial commit, d8fb8cf (2011).