Repository navigation
Conversation
jensmaurer
approved these changes
Nov 10, 2026
Member
|
@jwakely , this seems obvious, but is a change in normative text, so a second pair of eyes would be appreciated. |
jwakely
approved these changes
Nov 10, 2026
jwakely
left a comment
Member
There was a problem hiding this comment.
Probably just a copy&paste error. The normative text is inconsistent and nonsensical, and the fix is correct, so OK to fix editorially.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In [unord.set.cnstr], the
unordered_setconstructor takingfrom_range_tas its first parameter is incorrectly namedunordered_multiset.Rename it to
unordered_set, matching its declaration in [unord.set.overview] and the accompanying Effects paragraph.The typo was introduced in 6d4a94f, which applied P1206R7.