Skip to content

refactor!: own buffer_param and fix content encoding never finishing #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sgerbino merged 2 commits into from
Oct 30, 2026
Merged

refactor!: own buffer_param and fix content encoding never finishing #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b15ecfd
refactor!: own buffer_param and fix content encoding never finishing
sgerbino Oct 30, 2026
324fff5
fix: release zlib streams when content filters are destroyed
sgerbino Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/boost/http/concept/read_source.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ namespace http {
Successful partial reads are not permitted; either the entire
buffer is filled or the operation returns with an error.

If `buffer_empty( buffers )` is `true`, the operation completes
If `buffers_empty( buffers )` is `true`, the operation completes
immediately with `!ec` and `n` equal to 0.

When the buffer sequence contains multiple buffers, each buffer is
Expand Down
10 changes: 5 additions & 5 deletions include/boost/http/io/any_buffer_sink.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
#include <boost/capy/detail/await_suspend_helper.hpp>
#include <boost/capy/buffers.hpp>
#include <boost/capy/buffers/buffer_copy.hpp>
#include <boost/capy/buffers/buffer_param.hpp>
#include <boost/http/io/buffer_param.hpp>
#include <boost/http/concept/buffer_sink.hpp>
#include <boost/capy/concept/context_awaitable.hpp>
#include <boost/http/concept/write_sink.hpp>
Expand Down Expand Up @@ -1042,7 +1042,7 @@ template<capy::ConstBufferSequence CB>
capy::task<capy::results<std::size_t>>
any_buffer_sink::write_some(CB buffers)
{
capy::buffer_param<CB> bp(buffers);
buffer_param<CB> bp(buffers);
auto src = bp.data();
if(src.empty())
co_return {std::error_code(), 0};
Expand Down Expand Up @@ -1075,7 +1075,7 @@ template<capy::ConstBufferSequence CB>
capy::task<capy::results<std::size_t>>
any_buffer_sink::write(CB buffers)
{
capy::buffer_param<CB> bp(buffers);
buffer_param<CB> bp(buffers);
std::size_t total = 0;

// Native WriteSink path
Expand Down Expand Up @@ -1186,7 +1186,7 @@ any_buffer_sink::write_eof(CB buffers)
// Native WriteSink path
if(vt_->construct_write_eof_buffers_awaitable)
{
capy::const_buffer_param<CB> bp(buffers);
const_buffer_param<CB> bp(buffers);
std::size_t total = 0;

for(;;)
Expand Down Expand Up @@ -1215,7 +1215,7 @@ any_buffer_sink::write_eof(CB buffers)
}

// Synthesized path: prepare + capy::buffer_copy + commit + commit_eof
capy::buffer_param<CB> bp(buffers);
buffer_param<CB> bp(buffers);
std::size_t total = 0;

for(;;)
Expand Down
6 changes: 3 additions & 3 deletions include/boost/http/io/any_buffer_source.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
#include <boost/capy/detail/await_suspend_helper.hpp>
#include <boost/capy/buffers.hpp>
#include <boost/capy/buffers/buffer_copy.hpp>
#include <boost/capy/buffers/buffer_param.hpp>
#include <boost/http/io/buffer_param.hpp>
#include <boost/http/concept/buffer_source.hpp>
#include <boost/capy/concept/context_awaitable.hpp>
#include <boost/http/concept/read_source.hpp>
Expand Down Expand Up @@ -758,7 +758,7 @@ template<capy::MutableBufferSequence MB>
capy::task<capy::results<std::size_t>>
any_buffer_source::read_some(MB buffers)
{
capy::buffer_param<MB> bp(buffers);
buffer_param<MB> bp(buffers);
auto dest = bp.data();
if(dest.empty())
co_return {std::error_code(), 0};
Expand All @@ -782,7 +782,7 @@ template<capy::MutableBufferSequence MB>
capy::task<capy::results<std::size_t>>
any_buffer_source::read(MB buffers)
{
capy::buffer_param<MB> bp(buffers);
buffer_param<MB> bp(buffers);
std::size_t total = 0;

// Native ReadSource path
Expand Down
4 changes: 2 additions & 2 deletions include/boost/http/io/any_read_source.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
#include <boost/capy/detail/await_suspend_helper.hpp>
#include <boost/capy/buffers.hpp>
#include <boost/capy/detail/buffer_array.hpp>
#include <boost/capy/buffers/buffer_param.hpp>
#include <boost/http/io/buffer_param.hpp>
#include <boost/capy/concept/context_awaitable.hpp>
#include <boost/http/concept/read_source.hpp>
#include <boost/capy/ex/await_context.hpp>
Expand Down Expand Up @@ -572,7 +572,7 @@ template<capy::MutableBufferSequence MB>
capy::task<capy::results<std::size_t>>
any_read_source::read(MB buffers)
{
capy::buffer_param bp(buffers);
buffer_param bp(buffers);
std::size_t total = 0;

for(;;)
Expand Down
8 changes: 4 additions & 4 deletions include/boost/http/io/any_write_sink.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
#include <boost/capy/detail/await_suspend_helper.hpp>
#include <boost/capy/buffers.hpp>
#include <boost/capy/detail/buffer_array.hpp>
#include <boost/capy/buffers/buffer_param.hpp>
#include <boost/http/io/buffer_param.hpp>
#include <boost/capy/concept/context_awaitable.hpp>
#include <boost/http/concept/write_sink.hpp>
#include <coroutine>
Expand Down Expand Up @@ -222,7 +222,7 @@ class any_write_sink
Writes data from the provided buffer sequence. The operation
completes when all bytes have been consumed, or an error
occurs. Forwards to the underlying sink's `write` operation,
windowed through @ref capy::buffer_param when the sequence exceeds
windowed through @ref buffer_param when the sequence exceeds
the per-call buffer limit.

@param buffers The buffer sequence containing data to write.
Expand Down Expand Up @@ -854,7 +854,7 @@ template<capy::ConstBufferSequence CB>
capy::task<capy::results<std::size_t>>
any_write_sink::write(CB buffers)
{
capy::const_buffer_param<CB> bp(buffers);
const_buffer_param<CB> bp(buffers);
std::size_t total = 0;

for(;;)
Expand All @@ -877,7 +877,7 @@ template<capy::ConstBufferSequence CB>
capy::task<capy::results<std::size_t>>
any_write_sink::write_eof(CB buffers)
{
capy::const_buffer_param<CB> bp(buffers);
const_buffer_param<CB> bp(buffers);
std::size_t total = 0;

for(;;)
Expand Down
Loading
Loading