Repository navigation
Fix flaky macOS tests and make CrateLayer test failures readable - #849
Merged
Merged
Conversation
florinutz
approved these changes
Nov 4, 2026
|
|
||
| Unreleased | ||
| ================ | ||
| - Testing: ``CrateLayer.start()`` now raises ``SystemError`` when CrateDB does |
Contributor
There was a problem hiding this comment.
since start now returns an error and before this it didn't, and since this might concern other repos too (such as crate's blackbox tests and pytest-cratedb) is this more than a Testing change - maybe Breaking?
Contributor
Author
There was a problem hiding this comment.
Thanks, good point. crate.testing.layer ships with package, I checked that and crate/crate blackbox and crate/pytest-cratedb does not use this anymore. They shouldn't be affected with this change.
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes / Why this is an improvement
The macOS test jobs fail randomly in the CrateLayer tests, for example in https://github.com/crate/crate-python/actions/runs/40619105323/job/122588489678. The logs are also hard to read, because pytest prints the captured output of every passing test.
This PR fixes flakiness of the TestLayer and enable caching for crateDB for faster run time. and reduces verbose to have clean pipeline logs.
What changed?
Checklist