Repository navigation
Conversation
Signed-off-by: anna.stepanyan <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withLakebaseTraceContexthelper for direct Lakebase SQL in AppKit scaffolds. It reads the active OpenTelemetry span at query execution, adds a W3Ctraceparentcomment and sanitized service label, and preserves query parameters and sampling flags. Queries without a valid active span remain unchanged.Validation
pnpm build,pnpm docs:build,pnpm check:fix,pnpm -r typecheck,pnpm test(333 files and 6,174 tests passed; one skipped),pnpm check,pnpm docs:check,pnpm knip, license and template dependency checks, generated types and manifest sync, and public registry lockfile checks.Remaining verification
I could not read
system.lakebase.plan_historyfrom the available test workspace because the principal lacksUSE SCHEMAonsystem.lakebase. The live test above verifies SQL execution and span/comment identity, but a captured plan row remains unverified. This PR is a draft for that reason.The downstream app-templates repository is populated by AppKit's release sync; I validated its rendered Lakebase variant locally and am leaving that update to the existing sync process.