Repository navigation
Conversation
`air run` submits a databricks_ai_v* version as spec.base_environment (workspace-base-environments/databricks_ai_v6), but `air get` and the `air list` info pane read only spec.environment_version, so Environment showed N/A. Strip the shared prefix and show the configured version. Co-authored-by: Isaac <[email protected]>
Co-authored-by: Isaac <[email protected]>
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 1 tests: regression=1 unreleased=0 coverage=0 failing=0
TestAccept/air/get-databricks-ai: branch ✅ | main (2699068) ❌ | latest (v1.26.0) ❌main (2699068): latest (v1.26.0): same output as main (2699068) |
Collaborator
✅ Integration test reportCommit: 322abe3
Top 3 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
air getnow shows the environment, for exampledatabricks_ai_v6, for runs submitted withenvironment.version: databricks_ai_v*, instead ofEnvironment N/A. Theair listinfo pane renders through the same code and is fixed too.air runsubmits those versions asspec.base_environment = workspace-base-environments/<version>with noenvironment_version. The reader now strips that exact prefix, shared asworkspaceBaseEnvironmentPrefixwithbuildRunEnvironmentandconvert-to-dabs. Numeric versions are still read fromenvironment_version.Why
Every run on the Databricks AI environment, which most AI Runtime cookbook recipes use, showed
Environment N/A. Internal ticket: CNXT-2641.Tests
TestAiRuntimeEnvironmentVersion: numericenvironment_versionandbase_environmentcases; the second fails without the fix.acceptance/air/get-databricks-ai:air gettext output for adatabricks_ai_v6run. Fails without the fix (Environment N/A).go test ./cmd/air/...andgo test ./acceptance -run 'TestAccept/air/'pass;./task lint-qis clean. Unit tests ran withDATABRICKS_WORKSPACE_IDunset:TestLogsCommandRepeatsRunLinkAfterStreamingalso fails onmainwhen that variable is set.This pull request and its description were written by Isaac.