Repository navigation
Honor CloudFetch download settings on kernel connections - #1060
Open
aakash-saravanan-db wants to merge 3 commits into
Open
aakash-saravanan-db wants to merge 3 commits into
aakash-saravanan-db wants to merge 3 commits into
Conversation
Signed-off-by: Aakash Saravanan <[email protected]>
Signed-off-by: Aakash Saravanan <[email protected]>
Signed-off-by: Aakash Saravanan <[email protected]>
aakash-saravanan-db
temporarily deployed
to
azure-prod
November 14, 2026 04:11 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
aakash-saravanan-db
temporarily deployed
to
azure-prod
November 14, 2026 04:11 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
![peco-review-bot[bot]](https://avatars.githubusercontent.com/in/3801177?s=60&v=4){kind=small}
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or gap
Python applications could set
max_download_threadson Thrift connections, but kernel connections ignored it.What this PR addresses
Forward the existing setting to the kernel download window, default 10 (previously 16). Non-positive or non-integer values, including booleans, raise
ValueErrorwhen connecting withuse_kernel=True. Preserve explicit raw chunk overrides and document connection-time configuration, the 256 ceiling and the distinction from a byte limit.Dependencies
Existing native kernel APIs; no native dependency bump is required.
Tests and validation
349 focused tests pass; built-wheel checks verify controls, invalids, precedence, complete results and constrained consumption. With a native built from kernel
a488a05, after equal warmups and five alternating runs per side, DBSQL medians from submission through complete drain of 3M ordered rows: Thrift 10.36 s → kernel 8.86 s (-14.4%); kernel window 16 → 10: 9.04 s → 9.00 s (-0.5%).