Repository navigation
chore: standardize release workflows - #506
Open
mkuznyetsov wants to merge 1 commit into
Open
mkuznyetsov wants to merge 1 commit into
mkuznyetsov wants to merge 1 commit into
Conversation
- Update release commit message prefixes from 'ci:' to 'chore(release):' in make-release.sh - Add workflow run-name to typescript-publish.yml showing version/branch/SHA - Add parameter display step to typescript-publish.yml for release builds - Fix security issues: all GitHub context variables in shell commands now use environment variables Implements eclipse-che/che#23933 Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 483 483
Branches 86 83 -3
=========================================
Hits 483 483
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mkuznyetsov, svor The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements eclipse-che/che#23933
Changes
Updated release commit message prefixes from
ci:tochore(release):inmake-release.shCOMMIT_MSG="chore(release): bump ${VERSION} in ${X_BRANCH}"COMMIT_MSG="chore(release): bump ${NEXT_VERSION} in main"Added workflow run-name to
typescript-publish.ymlshowing version/branch/SHAAdded parameter display step to
typescript-publish.ymlfor release buildsFixed security issues: All GitHub context variables in shell commands now use environment variables
Testing
bash -n.github/workflows/typescript-publish.ymlandmake-release.shBefore/After Examples
make-release.sh
Before:
COMMIT_MSG="ci: bump ${VERSION} in ${X_BRANCH}"After:
COMMIT_MSG="chore(release): bump ${VERSION} in ${X_BRANCH}"typescript-publish.yml
Before: No run-name field, no parameter display, direct
${{ }}interpolation in shell commandsAfter: Run-name with version/branch/SHA, parameter display step, all shell commands use environment variables
🤖 Generated with Claude Code