Skip to content

chore: standardize release workflows - #506

Open
mkuznyetsov wants to merge 1 commit into
mainfrom
che-23933
Open

mkuznyetsov wants to merge 1 commit into
mainfrom
che-23933

Conversation

@mkuznyetsov

Copy link
Copy Markdown
Contributor

Implements eclipse-che/che#23933

Changes

  1. Updated release commit message prefixes from ci: to chore(release): in make-release.sh

    • Line 114: COMMIT_MSG="chore(release): bump ${VERSION} in ${X_BRANCH}"
    • Line 128: COMMIT_MSG="chore(release): bump ${NEXT_VERSION} in main"
  2. Added workflow run-name to typescript-publish.yml showing version/branch/SHA

    • For workflow_dispatch: Shows "Release {version} on {branch}"
    • For push: Shows "Build next for {branch} @ {sha}"
  3. Added parameter display step to typescript-publish.yml for release builds

    • Displays version, recreate tags flag, branch, commit SHA, and triggered by user
    • Only runs for workflow_dispatch events
  4. Fixed security issues: All GitHub context variables in shell commands now use environment variables

    • Updated "Validate parameters and build type" step
    • Updated "Check existing release tags" step
    • Updated "Build and publish release version" step
    • Updated "Build and publish next version" step

Testing

  • ✅ Verified YAML syntax with Python yaml parser
  • ✅ Verified bash script syntax with bash -n
  • ✅ Verified only release commits were modified (2 COMMIT_MSG lines)
  • ✅ Verified only 2 files modified: .github/workflows/typescript-publish.yml and make-release.sh

Before/After Examples

make-release.sh

Before:

COMMIT_MSG="ci: bump ${VERSION} in ${X_BRANCH}"

After:

COMMIT_MSG="chore(release): bump ${VERSION} in ${X_BRANCH}"

typescript-publish.yml

Before: No run-name field, no parameter display, direct ${{ }} interpolation in shell commands

After: Run-name with version/branch/SHA, parameter display step, all shell commands use environment variables

🤖 Generated with Claude Code

- Update release commit message prefixes from 'ci:' to 'chore(release):' in make-release.sh
- Add workflow run-name to typescript-publish.yml showing version/branch/SHA
- Add parameter display step to typescript-publish.yml for release builds
- Fix security issues: all GitHub context variables in shell commands now use environment variables

Implements eclipse-che/che#23933

Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com>
@coderabbitai

coderabbitai Bot commented Nov 5, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 40e61443-98f5-432a-90f7-ea37424198fd
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@codecov

codecov Bot commented Nov 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (afcaecb) to head (8d408eb).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #506   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          483       483           
  Branches        86        83    -3     
=========================================
  Hits           483       483           
Flag Coverage Δ
unit-tests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@svor svor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci Bot added the lgtm label Nov 5, 2026
@openshift-ci

openshift-ci Bot commented Nov 5, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mkuznyetsov, svor

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants