Repository navigation
Conversation
Deploying mouseterm with
|
| Latest commit: |
c6297cf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://36bafeb1.mouseterm.pages.dev |
| Branch Preview URL: | https://dor-v2-08-explicit-refs.mouseterm.pages.dev |
dormouse-bot
left a comment
There was a problem hiding this comment.
The --window synopses and placeholders still read label (dor list [--window label], dor list --workspaces [--window label], dor workspace [--window label]), but windowRefParser now refuses a bare label. An agent working from the synopsis will try --window ws-2 and be refused. The suggestions below fix the placeholders in the diff; list.ts's LIST_USAGE lines ([--window label], outside the diff) and the help snapshots need the same edit.
1f590c2 to
d566214
Compare
ab182bf to
5637b43
Compare
|
Re: dormouse-bot review —
Fixed everywhere. Every
The |
|
Confirmed at |
d566214 to
289f592
Compare
5637b43 to
33ef1b0
Compare
dormouse-bot
left a comment
There was a problem hiding this comment.
One spec sentence overstates what the Rust side shares (inline).
dormouse-bot
left a comment
There was a problem hiding this comment.
One stale contract comment outside the diff: MoveWorkspaceRequest in dor/src/commands/types.ts still says toWindow is "a label or new for a torn-out one". The renderer's workspace.move handler now refuses anything but window:<label> or new, so the comment should say window:<label>.
`workspace:<id>` resolves only an id and `workspace-name:<exact name>` only a name; bare Workspace and Window references are refused before any host request, and Window destinations require `window:<label>` (`[--window ref]` in every synopsis). `dor workspace move --new-window` replaces `--window new`, and `dor move <surface> --new-workspace` replaces `--new`. The CLI, renderer, VS Code guard, and Rust router share one grammar, with JSON cases checking TypeScript/Rust parity. `docs/dor-v2-migration.md` covers the whole dor 2.0 stack. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
289f592 to
8bbfa0d
Compare
6120d45 to
34e382f
Compare
Workspace references now choose one interpretation explicitly.
workspace:<id>resolves only an id.workspace-name:<exact name>resolves only a name, and keeps numeric names and whitespace. Bare Workspace and Window references are refused before any host request. Window destinations requirewindow:<label>, and every--windowsynopsis reads[--window ref].Creating a destination now has its own flag on both move commands:
dor workspace move --new-windowreplaces--window new.dor move <surface> --new-workspacereplaces--new. The privatesurface.movewire field stays{ new: true }.dor movechecks its destination reference before it contacts the host.The CLI, renderer, VS Code guard, and Rust router share one reference contract. Shared JSON cases (
dor/test/reference-cases.json) check TypeScript/Rust parity. The browser providers validate an intercepted--workspacebefore running the provider.send --stdin=truekeeps its position among ordered events. The website help-parser test finds the split-direction row by name.docs/dor-v2-migration.mdcovers the whole stack:--cwdrefusal--required only bydor split; browser providers stay drop-in, and named Tools are unchangedsendeventscommand_stateand exit 4--from--new-window, and--new-workspaceHelp, skill, fixtures, and specs are updated.
Stack: 8/8, based on #1744. Breaking change for Dormouse 2.0.
Validation on the complete stack:
pnpm testpassed:tsc --noEmit, 404 vitest (401 passed, 3 expected failures), and 48 script testspnpm buildpassed.Mutation checks:
dor move's early reference check lets a bare destination reach the host, which fails the move test.--newflag name fails both move tests.--stdin=truefrom the ordered-event scan fails the send test.--workspacevalidation fails the reference-prefix test, for agent-browser and for playwright.parseWorkspaceReffails the shared grammar test and three CLI tests.Windows-specific executable tests remain skipped on this macOS host. Native multi-window behavior is covered by the existing routing and transfer tests, not by a manual Windows run.