Skip to content

Add WP_SECRETS_KEY to our config - #1029

Merged
yosifkit merged 1 commit into
docker-library:masterfrom
infosiftr:WP_SECRETS_KEY
Nov 11, 2026
Merged

yosifkit merged 1 commit into
docker-library:masterfrom
infosiftr:WP_SECRETS_KEY

Conversation

@tianon

@tianon tianon commented Nov 11, 2026

Copy link
Copy Markdown
Member

See WordPress/WordPress@e9cf430

docker-library/official-images#22723 (comment):

I couldn't find tags on GitHub or Trac anywhere for the betas, but I verified via https://dezip.org/v1/6/https/wordpress.org/wordpress-7.2-beta5.tar.gz/wordpress/wp-config-sample.php that WordPress/WordPress@e9cf430 is included, so we should sync that into our config before we merge this.

Comment thread wp-config-docker.php
*
* @since 7.2.0
*/
define( 'WP_SECRETS_KEY', getenv_docker('WORDPRESS_SECRETS_KEY', 'put your unique phrase here') );

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure if our variable should be WP_SECRETS_KEY to be consistent with upstream or WORDPRESS_SECRETS_KEY to be consistent with our other variables, so I opted for the latter, but I'm very open to being convinced otherwise.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine. It follows what is already done for WP_DEBUG

@yosifkit
yosifkit merged commit 748a3ba into docker-library:master Nov 11, 2026
30 checks passed
@yosifkit
yosifkit deleted the WP_SECRETS_KEY branch November 11, 2026 21:46
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Nov 11, 2026
Changes:

- docker-library/wordpress@748a3ba: Merge pull request docker-library/wordpress#1029 from infosiftr/WP_SECRETS_KEY
- docker-library/wordpress@2e464c8: Add `WP_SECRETS_KEY` to our config
- docker-library/wordpress@d45ea0d: Update beta to 7.2-beta5
tianon pushed a commit to docker-library/official-images that referenced this pull request Nov 11, 2026
Changes:

- docker-library/wordpress@748a3ba: Merge pull request docker-library/wordpress#1029 from infosiftr/WP_SECRETS_KEY
- docker-library/wordpress@2e464c8: Add `WP_SECRETS_KEY` to our config
- docker-library/wordpress@d45ea0d: Update beta to 7.2-beta5

Co-authored-by: Docker Library Bot <doi+docker-library-bot@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants