Repository navigation
Publish job: install with npm 10, publish with npm 11 - #25
Merged
Merged
Conversation
npm 11's npm ci rejects package-lock.json (optional rollup platform packages missing), which failed the 4.1.0 publish on main. Install with Node 20's npm like the build job, then switch to npm >= 11.5.1 only for the trusted publish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the 4.1.0 publish on main failed before publishing:
npm ciwith npm 11 rejects our package-lock.json ("Missing: @rollup/rollup-darwin-arm64 ... from lock file", npm 11 is stricter about optional platform packages). the build job uses node 20 / npm 10 and passes.now the publish job installs with node 20's npm like the build job, and only upgrades to npm >= 11.5.1 for
npm publish(needed for trusted publishing).checked locally: npm 10
npm ci, then npm 11.21.2publish --dry-run: build, 44/44 tests, browser check, reaches the publish step. merging this publishes 4.1.0 (version is still newer than npm's 4.0.1).