Repository navigation
app-crypt/mit-krb5: remove outdated user patches - #4375
Merged
t-lo merged 1 commit intoNov 11, 2026
Merged
Conversation
Gentoo stabilised mit-krb5-1.22.2, no need to carry user patches anymore (also patches fail to apply now, breaking the build). Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Removing the NegoEx patch while the pinned Gentoo version lacks equivalent fixes reintroduces CVE-2026-40355 and CVE-2026-40356, so the patch must be retained or the Gentoo update included.
No open issues 🎉
What changed in this PR
Removes Flatcar’s mit-krb5 user patch to avoid patch-application failures with the 1.22.3 upgrade proposed in #4373.
Changes:
- Deletes the NegoEx security backport.
- Deletes the README documenting when that backport can be removed.
| File | Description |
|---|---|
| sdk_container/src/third_party/coreos-overlay/coreos/user-patches/app-crypt/mit-krb5/README.md | Removes the backport’s version-removal guidance. |
| sdk_container/src/third_party/coreos-overlay/coreos/user-patches/app-crypt/mit-krb5/0001-Fix-two-NegoEx-parsing-vulnerabilities.patch | Removes the backport for two NegoEx parsing vulnerabilities. |
Review effort: Balanced
Member
Author
Bad bot! The log clearly states: implying Gentoo ships mit-krb5-1.22.3, which includes the fixes and thus is not vulnerable. |
Contributor
|
Right, but that's not true in main? You should add this to the other PR. |
Member
Author
|
Merged into the buildbot branch. |
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gentoo stabilised mit-krb5-1.22.2, no need to carry user patches anymore (also patches fail to apply now, breaking the build).
This fixes
seen in #4373.