Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #2737 +/- ##
============================================
Coverage 91.01% 91.01%
- Complexity 0 32035 +32035
============================================
Files 2237 2238 +1
Lines 92557 92566 +9
============================================
+ Hits 84239 84248 +9
Misses 8318 8318 🚀 New features to boost your workflow:
|
|
|
||
| if ( | ||
| $oldUri->getHost() !== $newUri->getHost() | ||
| || $oldUri->getScheme() === 'https' && $newUri->getScheme() === 'http' |
There was a problem hiding this comment.
IMO this should be:
| || $oldUri->getScheme() === 'https' && $newUri->getScheme() === 'http' | |
| || ($oldUri->getScheme() === 'https' && $newUri->getScheme() === 'http') |
But Mago forces removal of parentheses, and the code's behavior can be different.
There was a problem hiding this comment.
hmm I wonder if we cuold maybe turn off that mago rule 🤔
There was a problem hiding this comment.
Reported to Mago: carthage-software/mago#2696
| */ | ||
| public static function toArray(): array | ||
| { | ||
| return array_column(self::cases(), 'value'); |
There was a problem hiding this comment.
Reported as it's false-positive IMO: carthage-software/mago#2695
There was a problem hiding this comment.
yea, but it can be written like that, I just think mago can't really follow the array_column magic here. Code below it can understands
return array_map(static fn (self $header): string => $header->value, self::cases());
| { | ||
| case Authorization = 'Authorization'; | ||
| case ProxyAuthorization = 'Proxy-Authorization'; | ||
| case Cookie = 'Cookie'; |
There was a problem hiding this comment.
It's still missing a lot of headers that are sensitive by default
Resolves: #xxx
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security