Repository navigation
Remote Filesystem mv/cp bug - #2738
Merged
Merged
Conversation
…rts for remote filesystems - S3 and Azure client configuration take an "http" key (timeout, max_duration, max_retries) that is part of the description, defaults 30 / 300 / 3 - the filesystem bundle takes client.http for aws_s3 and azure_blob, and options.copy_part_size for aws_s3 - S3 mv() sends one CopyObject up to copy_part_size (256 MiB) and a multipart copy in ranged parts above it, with the source metadata - S3 append builds its upload on the target key, the _flow_php_append_ object is gone - an append no longer deletes the original before its replacement exists, and an append without bytes keeps the content - a 200 response with error XML from CopyObject, UploadPartCopy or CompleteMultipartUpload throws before anything is deleted - mv() of an object onto itself sends no request - aws_s3_filesystem_options() DSL function, the default block size of the S3 destination stream is 5 MiB
…fter a confirmed copy - mv() copies synchronously: one Copy Blob up to copy_part_size (256 MiB), ranged blocks with the source properties above it - azure-sdk: copyBlob() is synchronous and throws on a pending copy, new putBlockBlobBlockFromBlob() - the copy source is signed with a read-only SAS for one blob, AuthorizationFactory::readOnlySourceUrl() - getBlobProperties() sends HEAD and no longer downloads the blob, BlobProperties::content() is removed - Options::withCopyPartSize() and the bundle options.copy_part_size for azure_blob - compose.yml.dist pins azurite to 3.37.0
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2738 +/- ##
============================================
+ Coverage 91.01% 91.04% +0.03%
- Complexity 32029 32121 +92
============================================
Files 2237 2237
Lines 92557 92882 +325
============================================
+ Hits 84239 84566 +327
+ Misses 8318 8316 -2 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #xxx
Change Log
Added
flow-php/filesystem-async-aws-bridge-httplimits (timeout, max_duration, max_retries) in the client configurationflow-php/filesystem-async-aws-bridge-Options::withCopyPartSize()andaws_s3_filesystem_options()flow-php/filesystem-azure-bridge-httplimits (timeout, max_duration, max_retries) in the blob service configurationflow-php/filesystem-azure-bridge-Options::withCopyPartSize()flow-php/azure-sdk-putBlockBlobBlockFromBlob()andAuthorizationFactory::readOnlySourceUrl()flow-php/azure-sdk- content headers and metadata onBlobPropertiesandPutBlockBlobBlockListOptionsflow-php/symfony-filesystem-bundle-client.httpandoptions.copy_part_sizefor aws_s3 and azure_blobFixed
flow-php/filesystem-async-aws-bridge-mv()of an object above 5 GB, now a multipart copy in ranged partsflow-php/filesystem-async-aws-bridge- append no longer deletes the original before its replacement existsflow-php/filesystem-async-aws-bridge- append without bytes no longer empties the objectflow-php/filesystem-async-aws-bridge- a 200 response with error XML no longer deletes the source of a moveflow-php/filesystem-azure-bridge-mv()no longer deletes the source of a pending copyflow-php/azure-sdk-getBlobProperties()sends HEAD and no longer downloads the blobChanged
flow-php/filesystem-async-aws-bridge- S3 calls default to a 30 s idle timeout and a 300 s total limitflow-php/filesystem-async-aws-bridge- append builds its upload on the target key, without the_flow_php_append_objectflow-php/filesystem-azure-bridge- requests default to a 30 s idle timeout, a 300 s total limit and 3 retriesflow-php/azure-sdk-copyBlob()is synchronous, signs the source and throws on a pending copyRemoved
flow-php/azure-sdk-BlobProperties::content()Deprecated
Security