Repository navigation
Name the stubbed helpers, and the fourth unswept tree - #38
Merged
Merged
Conversation
Two corrections, both of a list this page states and nothing checked. The skip line said 477 examples are skipped "because our shim stubs the matcher they need" and named none of them. Read out of spec_helper.rb, they are `ruby_exe` (:882), `ruby_cmd` (:883) and `output_to_fd` (:280). The docs site named two helpers that are IMPLEMENTED (`complain`, `output`) and missed `ruby_cmd` entirely; that is fixed in go-embedded-ruby/docs#47, and the same read is now a gate. The unswept trees are `library/`, `optional/`, `command_line/` and `security/`. `command_line/` -- 32 spec files -- was missing from that sentence here, in index.html, on the docs site and in the ruby README. The conformancefigure pin moves to v0.8.0, which reads every `def … raise SpecSkip` out of spec_helper.rb and judges this page in both directions: a helper called stubbed that is not, and a stubbed helper the page names nowhere. Verified with the exact published command this lane runs, fetched through the proxy: $ go run github.com/go-embedded-ruby/docs/tools/[email protected] --root . 6 total claim(s), 1 version claim(s) and 3 stubbed-helper mention(s) checked against the gate's 23672 at Ruby 4.0.9 (derived from RUBY_VERSION); the shim stubs output_to_fd, ruby_cmd, ruby_exe and it bites: with the line rewritten to "stubs `ruby_exe` and `complain`", the same command exits 1 naming list.html:75 and `complain`. ⛔ What it still cannot do: the completeness half applies only once a helper is named, so deleting the enumeration outright would leave nothing to be incomplete about and the lane would stay green. The docs repository closes that with a test over its own content tree; this page has no equivalent yet. Co-Authored-By: Claude Opus 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two corrections to lists this page states, and a pin bump so the first one stops being stated by hand.
The stubbed helpers
The skip line said 477 examples are skipped "because our shim stubs the matcher they need" and named none of them. Read out of
spec_helper.rb:SpecSkip)ruby_exe(:882),ruby_cmd(:883),output_to_fd(:280)complain(:249),output(:279),be_computed_by(:199)Naming none of them was the mild version. The docs site named two that are implemented and missed
ruby_cmdentirely — corrected in docs#47, where the same read became a gate.The direction matters: an example using a genuinely stubbed helper skips, but one using
complainruns and, when the behaviour is missing, fails. A reader told the list is "the matchers the shim stubs" and sent to look among the skips does not find it there.The fourth unswept tree
library/,optional/,command_line/andsecurity/.command_line/— 32 spec files — was missing from that sentence here, inindex.html, on the docs site and in the ruby README.The pin
conformancefiguremoves to v0.8.0, which reads everydef … raise SpecSkipout ofspec_helper.rband judges this page in both directions.Verified with the exact published command the lane runs, fetched through the proxy:
And it bites — with the line rewritten to "the shim stubs
ruby_exeandcomplain", the same command exits 1:⛔ What it still cannot do
The completeness half applies only once a helper is named, so deleting the enumeration outright would leave nothing to be incomplete about and this lane would stay green. The docs repository closes that with a test over its own content tree; this page has no equivalent yet. Stated rather than left to be discovered.
🤖 Generated with Claude Code