Repository navigation
fix(commerce-server): respect product listing channels in storefronts - #1532
Merged
sbolinger-godaddy merged 2 commits intoNov 6, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 959bd32 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sbolinger-godaddy
approved these changes
Nov 5, 2026
sbolinger-godaddy
left a comment
Collaborator
There was a problem hiding this comment.
Nice fix! Nothing major found, approving. A few small things you may want to look at, none of them blockers:
- Stale channel = empty store. If
GODADDY_CHANNEL_IDpoints at an inactive or unregistered channel, catalog-api-v2 treats it asin: []. Every list then comes back empty and every PDP returns 404, with no error. A warning log when an unfiltered list returns zero products, or a README note, would make that easier to debug. - Extra upstream call. Any
channelIdfilter makes the catalog API page through/v1/commerce/channelson each request (it has a TODO to cache this). Fine for now, just worth knowing. - SKU route isn't channel-filtered.
skus/[id]and cart-add byskuIdstill resolve off-channel SKUs. Low impact, but a short README note would help, since it currently says direct links return 404.
What I checked:
- Confirmed in catalog-api-v2 that
channelId: { eq }is supported and that products without channel assignments still match, so the "all channels" test matches real API behavior. - Checked out the branch:
typecheckis clean and all 257 server tests pass. - Didn't test against a live store.
sbolinger-godaddy
deleted the
respect-product-listing-channels-in-storefronts
branch
November 6, 2026 16:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Storefront product queries filtered by active status but ignored the configured Commerce channel. Products unavailable on the storefront’s channel could appear in lists and remain accessible through direct product links.
Apply the server-configured channel filter to product lists and product-detail eligibility checks. Products unavailable on that channel now return 404 from the detail route.
AAB already provisions
GODADDY_CHANNEL_ID; no new browser parameter or AAB configuration change is required.Validation