Repository navigation
refactor!: Rename CustomDeploymentProtectionRuleRequest to CreateCustomDeploymentProtectionRuleRequest and pass it by value - #4712
Open
JamBalaya56562 wants to merge 1 commit into
Conversation
…ustomDeploymentProtectionRuleRequest` and pass it by value BREAKING CHANGE: `CustomDeploymentProtectionRuleRequest` is renamed to `CreateCustomDeploymentProtectionRuleRequest`; `RepositoriesService.CreateCustomDeploymentProtectionRule` now takes it by value.
gmlewis
added
NeedsReview
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4712 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 204 204
Lines 19154 19154
=======================================
Hits 18895 18895
Misses 259 259 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates #3644.
BREAKING CHANGE:
CustomDeploymentProtectionRuleRequestis renamed toCreateCustomDeploymentProtectionRuleRequest;RepositoriesService.CreateCustomDeploymentProtectionRulenow takes it by value.This PR:
CustomDeploymentProtectionRuleRequesttoCreateCustomDeploymentProtectionRuleRequestto matchCreateCustomDeploymentProtectionRule(likeReviewCustomDeploymentProtectionRuleRequest).body-allowed-pointer-typesin.golangci.yml.The request schema of
POST /repos/{owner}/{repo}/environments/{environment_name}/deployment_protection_ruleshas no required properties, soIntegrationIDstays a*int64withomitempty. Thedeployment-protection-ruleresponse schema already matchesCustomDeploymentProtectionRule.