Repository navigation
fix(gapic-generator): avoid build log payloads when no handlers are attached - #19065
Open
daniel-sanche wants to merge 4 commits into
Open
daniel-sanche wants to merge 4 commits into
daniel-sanche wants to merge 4 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the client logging logic across the GAPIC generator templates and generated golden files by adding a check to ensure that the logger has active handlers (_LOGGER.hasHandlers()) before logging is enabled. It also introduces corresponding unit tests to verify that both synchronous and asynchronous gRPC logging interceptors require handlers to be present. I have no additional feedback to provide as the changes are consistent and well-tested.
daniel-sanche
marked this pull request as ready for review
November 13, 2026 04:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, api_core added opt-in debug logging. Currently, the logging interceptor builds log payloads on each rpc. If no loggers are attached, the logs are discarded. This can be costly (example: datastore query going from 6 to 20 seconds)
This PR adds an extra clause to the logging check, to skip creating logs if no handlers are attached
According to a benchmark, this takes a reference datastore query back from /9.23s back to baseline 1.38