Repository navigation
Conversation
- Bump maven-project-info-reports-plugin from 3.6.2 to 3.9.0 (MPIR-470 disables plugin processing on dependency POMs, stopping 12 unvetted third-party build-extension downloads during report generation and keeping license cells populated under Airlock). - Update google-http-client-assembly/assembly.xml report paths from target/site/ to target/reports/ for Doxia 2.0. - Pin maven-deploy-plugin 3.1.3 and maven-source-plugin 3.3.1 in parentless google-http-client-bom/pom.xml.
The package-phase execution in build/plugins kept an explicit 3.6.2 version, which overrode the 3.9.0 pin in pluginManagement. Remove it so that pluginManagement is the only pin.
hj690
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
MOSS requires that we build and release this repository with dependencies only from Airlock (
maven-3p-trusted). This PR removes the 12 missing-dependency alerts that the nightly Airlock audit reports for the dependency report.Problem
maven-project-info-reports-plugin:3.6.2processes the plugins of each dependency POM. For thedependenciesreport, Maven then downloads 12 unvetted build-extension POMs and JARs. Under strict Airlock, the license cells show-.google-http-client-bom/pom.xmldoes not pinmaven-deploy-pluginandmaven-source-pluginfor-DperformRelease=true.Fix
pom.xml: Bumpmaven-project-info-reports-pluginfrom3.6.2to3.9.0.MPIR-470stops plugin processing for dependency POMs. Remove the second version pin on thepackage-phase execution, so thatpluginManagementis the only pin.google-http-client-assembly/assembly.xml: Read the reports fromtarget/reports/, the output directory of Doxia 2.0.google-http-client-bom/pom.xml: Pinmaven-deploy-plugin:3.1.3andmaven-source-plugin:3.3.1.No runtime dependencies change.
Testing and verification
All results are for commit
05f56b69.mvn installwith the flags of.kokoro/build.shpasses. All 14 modules run version3.9.0of the plugin.mvn test dependency:analyze fmt:check -DfailOnWarning=truepasses (738 tests, 0 failures).mvn clean deploy -DperformRelease=trueto a local directory passes.maven-3p-trustedserves 1,429 of the 1,441 files that these builds download. The other 12 are POM files of conflict losers. Maven does not download their JARs.dependencies/*.htmlpages, and each license cell has a value.main.