Skip to content

perf(is_awaitable): skip coroutine type test -- 5.8% faster async list #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dexhunter wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf(is_awaitable): skip coroutine type test -- 5.8% faster async list #309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions src/graphql/pyutils/is_awaitable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from __future__ import annotations

import inspect
from types import CoroutineType, GeneratorType
from types import GeneratorType
from typing import TYPE_CHECKING, Any, TypeGuard

if TYPE_CHECKING:
Expand All @@ -19,18 +19,13 @@ def is_awaitable(value: Any) -> TypeGuard[Awaitable]:

Instead of testing whether the object is an instance of abc.Awaitable, we
check the existence of an `__await__` attribute. This is much faster.
Coroutine objects need no extra check, since they all have `__await__`.
"""
return (
# check for coroutine objects
isinstance(value, CoroutineType)
# check for old-style generator based coroutine objects
or (
isinstance(value, GeneratorType) # for Python < 3.11
and bool(value.gi_code.co_flags & CO_ITERABLE_COROUTINE)
)
# check for other awaitables (e.g. futures)
or hasattr(value, "__await__")
)
# check for old-style generator based coroutine objects (for Python < 3.11)
if type(value) is GeneratorType:
return value.gi_code.co_flags & CO_ITERABLE_COROUTINE != 0
# check for coroutines and other awaitables (e.g. futures)
return hasattr(value, "__await__")


def is_async_iterable(value: Any) -> TypeGuard[AsyncIterable]:
Expand Down
Loading