Repository navigation
util: Enforce the maximum outlier ejection percentage - #13178
Open
goutamadwant wants to merge 1 commit into
Open
goutamadwant wants to merge 1 commit into
goutamadwant wants to merge 1 commit into
Conversation
Check the prospective ejected endpoint count before either outlier detection algorithm ejects another endpoint. Use integer arithmetic to respect exact percentage boundaries, and cover both algorithms and existing ejections with regression tests. Fixes grpc#13164
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check whether ejecting one more endpoint would exceed maxEjectionPercent in both the success-rate and failure-percentage algorithms. For example, a 30% limit with five endpoints now permits one ejection instead of two, matching the updated A50 contract.
Use integer cross-multiplication to preserve exact percentage boundaries without floating-point rounding. Add regression coverage for fractional and exact limits, zero, limits below one endpoint, existing ejections, both algorithms enabled, and a single endpoint at 100%.
Fixes #13164
Validation:
Commands:
The full repository build and hosted CI have not been run.