Repository navigation
Conversation
JmdnsHomekitAdvertiser created its own JmDNS when given an InetAddress but never closed it, and registered a shutdown hook on every advertise() that was never removed. Each stopped HomekitRoot therefore left a running JmDNS instance behind, kept reachable by its shutdown hook. stop() now removes the shutdown hook, closes the JmDNS only if the advertiser created it, and resets the advertising state so later changes to discoverability, MAC or configuration index do not re-register the service.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
HomekitServeris created with anInetAddress,JmdnsHomekitAdvertisercreates its ownJmDNSinstance.HomekitRoot.stop()never closed it, and everyadvertise()registered a shutdown hook that was never removed. Each stopped root therefore left a runningJmDNSinstance (with its threads) behind, kept reachable by the shutdown hook. Applications that stop and recreate the bridge, e.g. on network changes, accumulate these instances over time.Change
JmdnsHomekitAdvertiser.stop()now:advertise()JmDNSinstance only if the advertiser created it; aJmDNSpassed in by the caller stays opensetDiscoverable,setMacandsetConfigurationIndexafterstop()do not re-register the serviceNo public API changes.
Tests
testStopClosesOwnedJmdnstestStopDoesNotCloseSuppliedJmdnstestSetDiscoverableAfterStopDoesNotRegisterThe first and third fail without the fix.