Repository navigation
Conversation
Collaborator
|
Nice! What happens if you run the existing benchmarks suite (possibly with an update to include existing Immer 11.x as a comparison point)? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scope.drafts_now holds the draft states, not the draft proxies. Before this change,revokeDraftreaddraft[DRAFT_STATE], and each read ran the proxygettrap. NowrevokeDraftgets the state directly. The output does not change.Built
dist/cjsproduction code, ns/op:produceon a small object with no writesautoFreeze: falseI measured no slowdown on 29 benchmarks. These include Map and Set drafts, patches,
createDraftandfinishDraft, and array methods. Some small benchmarks change by 10-20% between rounds. On those benchmarks, I measured no significant change. I used 12 interleaved rounds and a Mann-Whitney test (Apple M2 Max, Node 24.15.0). I did not measure the speed on other engines.Checks:
yarn testpasses.