Skip to content

Repository navigation

Don't throw when the module is imported outside the native runtime #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
niamh-coleman wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Don't throw when the module is imported outside the native runtime #478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions __tests__/importOutsideNativeRuntime.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
describe('importing the module', () => {
test('does not throw without the native modules', () => {
jest.isolateModules(() => {
const { NativeModules } = require('react-native');
expect(NativeModules.IntercomEventEmitter).toBeUndefined();
expect(NativeModules.IntercomModule).toBeUndefined();

const { IntercomEvents } = require('../src');

expect(IntercomEvents.IntercomUnreadCountDidChange).toBeUndefined();
});
});

test('reads event names and methods from the native modules', () => {
jest.isolateModules(() => {
jest.doMock('../src/nativeModules', () => ({
IntercomModule: {
setNeedsStatusBarAppearanceUpdate: jest.fn(() =>
Promise.resolve(true)
),
},
IntercomEventEmitter: {
UNREAD_COUNT_CHANGE_NOTIFICATION: 'unread',
WINDOW_DID_HIDE_NOTIFICATION: 'hide',
WINDOW_DID_SHOW_NOTIFICATION: 'show',
},
}));
const { IntercomModule } = require('../src/nativeModules');
const { default: Intercom, IntercomEvents } = require('../src');

expect(IntercomEvents).toEqual({
IntercomUnreadCountDidChange: 'unread',
IntercomWindowDidHide: 'hide',
IntercomWindowDidShow: 'show',
IntercomHelpCenterWindowDidShow: 'show',
IntercomHelpCenterWindowDidHide: 'hide',
});

Intercom.setNeedsStatusBarAppearanceUpdate();
expect(
IntercomModule.setNeedsStatusBarAppearanceUpdate
).toHaveBeenCalledTimes(1);
});
});
});
14 changes: 8 additions & 6 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,17 @@ export enum ThemeMode {

type ThemeModeType = keyof typeof ThemeMode;

// Optional so that importing outside the native runtime, such as an Expo Router
// server export, doesn't throw.
export const IntercomEvents = {
IntercomUnreadCountDidChange:
IntercomEventEmitter.UNREAD_COUNT_CHANGE_NOTIFICATION,
IntercomWindowDidHide: IntercomEventEmitter.WINDOW_DID_HIDE_NOTIFICATION,
IntercomWindowDidShow: IntercomEventEmitter.WINDOW_DID_SHOW_NOTIFICATION,
IntercomEventEmitter?.UNREAD_COUNT_CHANGE_NOTIFICATION,
IntercomWindowDidHide: IntercomEventEmitter?.WINDOW_DID_HIDE_NOTIFICATION,
IntercomWindowDidShow: IntercomEventEmitter?.WINDOW_DID_SHOW_NOTIFICATION,
IntercomHelpCenterWindowDidShow:
IntercomEventEmitter.WINDOW_DID_SHOW_NOTIFICATION,
IntercomEventEmitter?.WINDOW_DID_SHOW_NOTIFICATION,
IntercomHelpCenterWindowDidHide:
IntercomEventEmitter.WINDOW_DID_HIDE_NOTIFICATION,
IntercomEventEmitter?.WINDOW_DID_HIDE_NOTIFICATION,
};

export enum Space {
Expand Down Expand Up @@ -425,7 +427,7 @@ const Intercom: IntercomType = {
IntercomModule.setLauncherVisibility(visibility),

setNeedsStatusBarAppearanceUpdate: Platform.select({
ios: IntercomModule.setNeedsStatusBarAppearanceUpdate,
ios: () => IntercomModule.setNeedsStatusBarAppearanceUpdate(),
default: async () => true,
}),

Expand Down
Loading