Repository navigation
chore(lint): lint JSDoc and run ESLint in npm run lint - #4844
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
changed the title
thetaPC
marked this pull request as ready for review
November 12, 2026 23:52
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue URL: N/A
What is the current behavior?
*or drift out of alignment, like theBestPracticeFigurecomment fixed in chore(styles): match Docusaurus' stylesheet layout #4834.npm run eslintandnpm run lint.Card-*classes declared inside its CSS module.What is the new behavior?
eslint-plugin-jsdocwithcheck-alignmentandrequire-asterisk-prefixonsrc, including.tsfiles. The ejectedprism-include-languages.tsis skipped, since its disable comment names a rule from a plugin we don't install.npm run lintruns ESLint, then Prettier. Theeslintscript and its CI step are removed, so ESLint now runs in the Lint job. CONTRIBUTING points atnpm run lint.styles.headerandstyles.iconRow. Nothing outside DocsCard used theCard-*names.Does this introduce a breaking change?
Other information
npm run lintreports ESLint errors but does not pass--fix, because the JSDoc autofix strips the indentation inside the comment and leaves trailing spaces.The DocsCard stylesheet compiles to the same rules before and after, once the old class names are mapped to the new ones.