Repository navigation
Conversation
…obMoveEnd event details
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 of 2 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Currently, the Range docs only describe
valuein theionKnobMoveStartandionKnobMoveEndevent details, and the knob move playground uses a single knob range, so it can't show which knob moved.What is the new behavior?
The Event Handling section now explains the
knobandpositionfields that ionic-team/ionic-framework#31754 adds to both events. It links to the CSS Shadow Parts section, since the fields use the same static identity and dynamic position as the knob parts. The Interfaces section addsknobandpositionto both event details, along with the newRangeKnobMoveStartCustomEventandRangeKnobMoveEndCustomEventinterfaces and theRangeKnobNameandRangeKnobPositiontypes.The
ion-knob-move-eventplayground now uses dual knobs starting at 20 and 80, and every framework logsknobandpositionnext tovalue. The Angular example uses the new custom event types instead ofRangeCustomEvent.Does this introduce a breaking change?
Other information