Repository navigation
fix(config): keep the app's rippleEffect over the theme config - #31635
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
force-pushed
the
FW-7803
branch
from
October 22, 2026 20:10
479022f to
a36544b
Compare
brandyscarney
marked this pull request as ready for review
October 22, 2026 20:39
brandyscarney
changed the title
brandyscarney
force-pushed
the
FW-7803
branch
from
November 12, 2026 22:24
0bd49a6 to
dd4e591
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
initialize()applies the app config first and the custom theme'sconfigblock on top, so the theme wins. If a custom theme setsrippleEffect: true, an app that setsrippleEffect: falsestill gets ripples.What is the new behavior?
rippleEffectset by the app is kept over the theme's value. When the app doesn't set it, the theme's value applies as before.DEPRECATED_THEME_CONFIG_KEYS. Per the App and Theme Config design doc,rippleEffectbecomes theme config, and the app key keeps working through v10. Other theme keys such asformHighlightandscreenBreakpointsare theme-owned, so the theme still wins for them.Does this introduce a breaking change?