Repository navigation
fix(breadcrumb, item-option): pass rel to the link - #31726
Open
adityajai119 wants to merge 1 commit into
Open
adityajai119 wants to merge 1 commit into
adityajai119 wants to merge 1 commit into
Conversation
|
@adityajai119 is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
3 tasks done
Both components declare and document a rel prop, but only passed download, href and target to the rendered anchor. ion-button and ion-item already pass rel. resolves ionic-team#31725
adityajai119
force-pushed
the
fix-breadcrumb-item-option-rel
branch
from
November 13, 2026 09:29
d8b0591 to
8259fce
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31725
What is the current behavior?
ion-breadcrumbandion-item-optiondeclare and document arelprop, but the<a>they render withhrefonly getsdownload,hrefandtarget. Therelvalue is dropped.ion-buttonandion-itemalready passrelto their<a>.What is the new behavior?
ion-breadcrumbpassesrelto its<a>.ion-item-optionpassesrelto its<a>.relattribute on the rendered link.Does this introduce a breaking change?
Other information
relon the breadcrumb and item-option links, andrel="nofollow"on theion-buttonlink.main(Expected: "noopener noreferrer",Received: null) and pass with this change.stencil test --specforbreadcrumb,breadcrumbs,item-optionanditem-sliding: 5 suites, 9 tests pass.AI-assisted: drafted with an AI coding agent; the tests above were run locally.