Repository navigation
feat(note): sync the ios theme with iOS 17 - #31732
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
left a comment
brandyscarney
left a comment
Member
There was a problem hiding this comment.
One concern with the alignment, but that's it!
brandyscarney
approved these changes
Nov 12, 2026
ShaneK
approved these changes
Nov 12, 2026
ShaneK
left a comment
ShaneK
left a comment
Member
There was a problem hiding this comment.
The ios sync looks good. Left one small docs suggestion on the font size revert step.
|
|
||
| In the `ios` theme, the note now matches the detail text of an iOS list row, in accordance with the iOS guidelines: | ||
|
|
||
| - The font size is now `17px` instead of `16px`. To revert to the previous appearance, set `IonNote.font.size` for global styles, or `--ion-note-font-size` for component-specific styles. |
Member
There was a problem hiding this comment.
Suggested change
| - The font size is now `17px` instead of `16px`. To revert to the previous appearance, set `IonNote.font.size` for global styles, or `--ion-note-font-size` for component-specific styles. | |
| - The font size is now `17px` instead of `16px`. To revert to the previous appearance, set `IonNote.font.size` to `max(14px, 1rem)` for global styles, or `--ion-note-font-size` for component-specific styles. |
The other revert steps here name the value to set, but this one doesn't. The old value wasn't a flat 16px, it was max(14px, 1rem), so anyone who guesses 16px from this line loses rem scaling. With a 20px root font size the note renders at 16px instead of the old 20px. Could we name it here?
# Conflicts: # BREAKING.md
# Conflicts: # BREAKING.md
Co-authored-by: Shane <[email protected]>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
The ios note is 16px with an inherited line height and letter spacing, values carried over from v9 instead of iOS 17.
What is the new behavior?
The ios note matches the detail text of an iOS 17 list row (Body, from the Apple Design Resources kit):
1.294line height, which is 22px at 17px-0.0235emletter spacing, which is -0.4px at 17pxLine height and letter spacing are new
IonNotetokens. md and ionic don't set them, so they keep inheriting as before.Does this introduce a breaking change?
The ios note is larger and now sets its line height and letter spacing. To revert to the previous appearance, set
IonNote.font.size,IonNote.line.heightandIonNote.letterSpacingfor global styles, or--ion-note-font-size,--ion-note-line-heightand--ion-note-letter-spacingfor component-specific styles.Other information
Known gaps
The ios note color still uses the text color step. iOS 17's secondary label color needs different values in dark mode, which palettes can't set for a component yet. Tracked as a follow-up.
How to test
line-heightis about 22px andletter-spacingis about -0.4pxOnly ios snapshots change: note basic, a11y and hue, and card basic, whose rows show a note.