Repository navigation
fix(chip): show the activated background when pressing a hovered chip - #31736
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ShaneK
approved these changes
Nov 12, 2026
ShaneK
left a comment
Member
There was a problem hiding this comment.
Thanks for this! The reorder matches the focus, hover, activated order from the recipes doc, and the new test covers every hue, fill and color combo. Left one tiny optional nit, feel free to ignore it.
Co-authored-by: Shane <[email protected]>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Pressing a hovered chip with a mouse keeps the hover background instead of the activated one, because
chip.scsswrites the activated rules before the focus and hover rules. In the ios and md themes, the background stays at the hover opacity (0.16) instead of the activated one (0.2). The ionic theme doesn't set separate hover or activated backgrounds, so it looks the same either way.What is the new behavior?
Does this introduce a breaking change?
Other information
nexthas the same order, so this is a fix rather than a migration regression. Raised in the review of #31727.To check by hand, use a mouse on the chip basic page in the ios theme, then hover a chip and hold the mouse button down. The background should darken past the hover color.