Repository navigation
fix(label): render content set with innerHTML - #31739
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ShaneK
approved these changes
Nov 12, 2026
ShaneK
left a comment
ShaneK
left a comment
Member
There was a problem hiding this comment.
Thanks for adding this test! LGTM 🚀
github-merge-queue
Bot
removed this pull request from the merge queue because a pull request earlier in the stack was removed
Nov 12, 2026
github-merge-queue
Bot
removed this pull request from the merge queue because a pull request earlier in the stack was removed
Nov 12, 2026
github-merge-queue
Bot
removed this pull request from the merge queue because a pull request earlier in the stack was removed
Nov 12, 2026
Add regression tests for content set with innerHTML and innerText on ion-label. The fix comes from the @stencil/core 4.45.3 update.
brandyscarney
force-pushed
the
FW-7890-fix-label-innerhtml
branch
from
November 12, 2026 18:48
d5cadc3 to
809f467
Compare
brandyscarney
enabled stacked auto-merge
November 12, 2026 18:49
ShaneK
pushed a commit
to masimplo/ionic-framework
that referenced
this pull request
Nov 12, 2026
Issue number: resolves ionic-team#31433 --------- ## What is the current behavior? Ionic uses `@stencil/core` 4.45.2. On scoped components, setting `innerHTML` or `innerText` removes a marker node Stencil uses to track slotted content, so the content is hidden on the next render. ## What is the new behavior? - Updates `@stencil/core` to 4.45.3, which patches the `innerHTML` and `innerText` setters on scoped components (stenciljs/core#6997). ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information Regression tests for `ion-label` are added in ionic-team#31739, which is stacked on this PR. Co-authored-by: Brandy Smith <[email protected]>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Binding
innerHTML(for example Angular's[innerHTML]) or settinginnerTexton anion-labelhides the label after its next render.What is the new behavior?
innerHTMLorinnerTextrenders and stays visible across re-renders.label/test/basic.Does this introduce a breaking change?
Other information
Stacked on #31738, which updates
@stencil/coreto 4.45.3 and resolves #31433. Without that update these tests fail.