Repository navigation
feat(note): sync the ionic theme with the design kit - #31742
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…rk into FW-6855-ionic-sync
brandyscarney
approved these changes
Nov 12, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
The ionic note inherits its line height and letter spacing.
What is the new behavior?
The ionic note matches the info text of a list item in the ionic theme's design kit (
body/md/regular):1.5rem(24px) line height0letter spacingThe 14px font size and regular weight already match.
Does this introduce a breaking change?
The ionic theme hasn't been released.
Other information
Known gaps
#6c727a) isn't in the palette, so the note keeps its current color. Tracked as a follow-up with the palette generatorHow to test
line-heightis 24px andletter-spacingis 0font-size: 310%tohtml. Rows with a note are slightly taller after, because the note's line height scales with the textOnly the ionic font scaling snapshot changes. At 100% the note fits within the item's minimum height, so nothing else moves.