Skip to content

test(segment-view): load the dynamic height image locally - #31745

Merged
brandyscarney merged 1 commit into
mainfrom
segment-view-local-image
Nov 12, 2026
Merged

brandyscarney merged 1 commit into
mainfrom
segment-view-local-image

Conversation

@thetaPC

@thetaPC thetaPC commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Issue number: internal

What is the current behavior?

The segment-view: dynamic height test waits for an image from picsum.photos. When that service is down, the test times out on Mobile Safari and fails every PR.

What is the new behavior?

  • The test and its page load a local 200×300 placeholder image.

Does this introduce a breaking change?

  • Yes
  • No

@vercel

vercel Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ionic-framework Ready Ready Preview Nov 12, 2026 6:16pm UTC

Request Review

@github-actions github-actions Bot added the package: core @ionic/core package label Nov 12, 2026
@thetaPC
thetaPC marked this pull request as ready for review November 12, 2026 18:27
@thetaPC
thetaPC requested a review from a team as a code owner November 12, 2026 18:27
@thetaPC
thetaPC requested a review from ShaneK November 12, 2026 18:28
@brandyscarney
brandyscarney added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit c9b5883 Nov 12, 2026
56 checks passed
@brandyscarney
brandyscarney deleted the segment-view-local-image branch November 12, 2026 18:42

This branch was successfully deployed

1 active deployment
Preview — 4d416ee1 Deployed Nov 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants