Repository navigation
Conversation
Context.RealIP fell back to net.SplitHostPort and ignored its error, so a RemoteAddr holding just an IP (no :port) came back as an empty string. Use extractIP, the helper ExtractIPDirect already uses, which accepts both forms. Backport of labstack#3054.
Member
|
Resolved by #3197 and released in v4.16.3: https://github.com/labstack/echo/releases/tag/v4.16.3 The released RealIP fallback calls extractIP, and its regression tests cover bare IPv4 and IPv6 RemoteAddr values. Closing this superseded backport as completed by the security fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #3054 to v4.
When no
IPExtractoris set,Context.RealIP()falls back tonet.SplitHostPort(RemoteAddr)and ignores the error. IfRemoteAddris a bare IP with no port (some listeners and proxies produce this), it returns an empty string.This switches the fallback to
extractIP, the helperExtractIPDirectalready uses, which handles bothip:portand a bare IP.Added bare IPv4 and IPv6
RemoteAddrcases toTestContext_RealIP. They fail before the change and pass after.go test ./...passes.