Repository navigation
TPT-4472: Create tests for stream commands - #901
Draft
psnoch-akamai wants to merge 4 commits into
Draft
psnoch-akamai wants to merge 4 commits into
psnoch-akamai wants to merge 4 commits into
Conversation
psnoch-akamai
changed the title
psnoch-akamai
force-pushed
the
TPT-4472-linode-cli-create-integration-tests-for-new-commands
branch
from
November 4, 2026 16:15
ef2bcee to
46eb9cb
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Negative tests assume ID 1 is invalid and can delete unrelated destinations or create unmanaged streams, while fixture defects cause setup failures and incomplete cleanup.
5 open issues
What changed in this PR
Adds integration coverage for the CLI’s stream and destination commands, including error handling and resource lifecycle checks.
Changes:
- Adds help, listing, and negative-command tests, with smoke coverage for listings.
- Exercises destination creation, viewing, history, and deletion, plus an opt-in long-running stream test.
- Adds resource fixtures, status polling, and shared command registration.
| File | Description |
|---|---|
tests/integration/streams/test_streams.py |
Tests stream help, listing, errors, creation, and viewing. |
tests/integration/streams/test_destination.py |
Tests destination listing, errors, lifecycle, and history. |
tests/integration/streams/fixtures.py |
Provides storage-key, destination, and stream fixtures with cleanup and polling. |
tests/integration/helpers.py |
Registers streams in the shared command map. |
Review effort: Balanced
Comment on lines
+23
to
+24
| host = os.getenv("LINODE_CLI_API_HOST") | ||
| if token is None: |
| @pytest.fixture | ||
| def create_object_storage_keys(): | ||
| label = get_random_text(8) + "_destination_cli_test" | ||
| test_bucket = get_object_storage_buckets()["data"][0] |
…est_create_view_stream
psnoch-akamai
force-pushed
the
TPT-4472-linode-cli-create-integration-tests-for-new-commands
branch
from
November 6, 2026 15:41
46eb9cb to
ef70629
Compare
Comment on lines
+124
to
+125
| "--details.access_key_secret", | ||
| create_object_storage_keys[1], |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Create tests for stream commands
✔️ How to Test