Skip to content

feat: show sched and luma identities in the ui - #5346

Open
joanagmaia wants to merge 1 commit into
mainfrom
feat/issue-1144-sched-luma-identities
Open

joanagmaia wants to merge 1 commit into
mainfrom
feat/issue-1144-sched-luma-identities

Conversation

@joanagmaia

Copy link
Copy Markdown
Contributor

Summary

Member profiles showed Sched and Luma identities with the generic fallback icon, because the UI had no identity entry for the sched and luma platforms. This adds both, with their name, logo and placeholder, so they render like Cvent.

Changes

  • New identity configs for sched and luma, registered in lfIdentities. The logos are each company's own app icon, served from its website (Sched 256×256, Luma 512×512).
  • sched and luma added to the system verifiers and the organization source labels, next to cvent. Their identities already show as auto-verified today, because the data sink leaves verifiedBy empty, so this keeps the lists complete rather than changing what users see.
  • sched data comes from the historical import in feat: add a script to import past sched events #5344. Luma data already exists on staging.

Type of change

  • Bug fix
  • New feature
  • Refactor / cleanup
  • Performance improvement
  • Chore / dependency update
  • Documentation

Related issue

Closes linuxfoundation/lfx-cdp-insights-ops#1144

Frontend checklist

  • npm run lint passes with 0 warnings
  • npm run typecheck error count: before 0, after 0 (must not rise)
  • npm run build:production passes
  • Screenshots for UI changes
  • Bundle size delta for dependency bumps (npm run analyze): no dependency changes
  • Other open PRs touching the same files: none

Copilot AI balanced review requested due to automatic review settings November 13, 2026 17:44
@cursor

cursor Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Frontend-only identity and label registration; no auth, API, or data-handling changes.

Overview
Member profiles that include Sched and Luma identities now use dedicated UI configs instead of the generic fallback icon.

The PR adds luma and sched identity configs (display name, logo asset, member placeholder) and registers them in lfIdentities, mirroring platforms like Cvent. Organization types gain LUMA and SCHED organization sources, and verification helpers list both as system verifiers with human-readable source labels so auto-verified identities from those integrations stay consistent in the UI.

Reviewed by Cursor Bugbot for commit 456b309. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

greptile-apps Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Adds Sched and Luma names, logos, and input placeholders to the shared identity registry.

  • Member profiles can show Sched and Luma identities with their own names and logos.
  • Verification details recognize Luma and Sched as sources and system verifiers.

Reviews (1) · Last reviewed commit: "feat: show sched and luma identities in ..." · Reviewed by Greptile

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the Sched and Luma identity support changes.

No open issues 🎉

What changed in this PR

Adds frontend support for Sched and Luma identities so member profiles display platform-specific names and logos instead of generic fallback icons.

Changes:

  • Adds Sched and Luma identity configurations with local logo references and input placeholders.
  • Registers both platforms in the shared identity catalog.
  • Adds organization source values, display labels, and system verifier entries for both platforms.
File Description
frontend/​src/​shared/​modules/​verification/​verification.helpers.ts Adds system verifier entries and source labels for both platforms.
frontend/​src/​modules/​organization/​types/​Organization.ts Adds Luma and Sched organization source values.
frontend/​src/​config/​identities/​sched/​config.ts Defines Sched’s name, logo reference, and placeholder.
frontend/​src/​config/​identities/​luma/​config.ts Defines Luma’s name, logo reference, and placeholder.
frontend/​src/​config/​identities/​index.ts Registers both identity configurations.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants