Repository navigation
feat: show sched and luma identities in the ui - #5346
joanagmaia wants to merge 1 commit into
Conversation
Refs linuxfoundation/lfx-cdp-insights-ops#1144 Signed-off-by: Joana Maia <[email protected]>
PR SummaryLow Risk Overview The PR adds Reviewed by Cursor Bugbot for commit 456b309. Bugbot is set up for automated code reviews on this repo. Configure here. |
[Medium impact] The PR appears safe to merge. SummaryAdds Sched and Luma names, logos, and input placeholders to the shared identity registry.
Reviews (1) · Last reviewed commit: "feat: show sched and luma identities in ..." · Reviewed by Greptile |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the Sched and Luma identity support changes.
No open issues 🎉
What changed in this PR
Adds frontend support for Sched and Luma identities so member profiles display platform-specific names and logos instead of generic fallback icons.
Changes:
- Adds Sched and Luma identity configurations with local logo references and input placeholders.
- Registers both platforms in the shared identity catalog.
- Adds organization source values, display labels, and system verifier entries for both platforms.
| File | Description |
|---|---|
frontend/src/shared/modules/verification/verification.helpers.ts |
Adds system verifier entries and source labels for both platforms. |
frontend/src/modules/organization/types/Organization.ts |
Adds Luma and Sched organization source values. |
frontend/src/config/identities/sched/config.ts |
Defines Sched’s name, logo reference, and placeholder. |
frontend/src/config/identities/luma/config.ts |
Defines Luma’s name, logo reference, and placeholder. |
frontend/src/config/identities/index.ts |
Registers both identity configurations. |
Review effort: Balanced
Summary
Member profiles showed Sched and Luma identities with the generic fallback icon, because the UI had no identity entry for the
schedandlumaplatforms. This adds both, with their name, logo and placeholder, so they render like Cvent.Changes
schedandluma, registered inlfIdentities. The logos are each company's own app icon, served from its website (Sched 256×256, Luma 512×512).schedandlumaadded to the system verifiers and the organization source labels, next tocvent. Their identities already show as auto-verified today, because the data sink leavesverifiedByempty, so this keeps the lists complete rather than changing what users see.scheddata comes from the historical import in feat: add a script to import past sched events #5344. Luma data already exists on staging.Type of change
Related issue
Closes linuxfoundation/lfx-cdp-insights-ops#1144
Frontend checklist
npm run lintpasses with 0 warningsnpm run typecheckerror count: before0, after0(must not rise)npm run build:productionpassesnpm run analyze): no dependency changes